Prevent RangeError for belongs_to associations
#25280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kaspth (@rails-bot has picked a reviewer for you, use r? to override) |
kamipo
force-pushed
the
prevent_range_error_for_belongs_to_associations
branch
3 times, most recently
from
c89a0ad
to
dbd0863
Compare
|
r? @sgrif |
kamipo
changed the title
RangeError for belongs_to associatonsRangeError for belongs_to associations
kamipo
force-pushed
the
prevent_range_error_for_belongs_to_associations
branch
4 times, most recently
from
ad08ddb
to
c32bc15
Compare
kamipo
force-pushed
the
prevent_range_error_for_belongs_to_associations
branch
from
c32bc15
to
b0e460f
Compare
kamipo
force-pushed
the
prevent_range_error_for_belongs_to_associations
branch
2 times, most recently
from
c1c8b56
to
dc45482
Compare
kamipo
force-pushed
the
prevent_range_error_for_belongs_to_associations
branch
from
dc45482
to
c969bfe
Compare
Currently to access `belongs_to` associations raises a `RangeError` if foreign key attribute has out of range value. It should return a nil value rather than raising a `RangeError`. Fixes rails#20140.
kamipo
force-pushed
the
prevent_range_error_for_belongs_to_associations
branch
from
c969bfe
to
0da4a08
Compare
|
Excellent! 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently to access
belongs_toassociations raises aRangeErrorifforeign key attribute has out of range value.
It should return a nil value rather than raising a
RangeError.Fixes #20140.