Require "active_support/core_ext/object/blank" for railties abstract unit #25390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
gsamokovarov
force-pushed
the
abstact-unit-presence-require
branch
from
4ab3964
to
ec41f61
Compare
| @@ -1,5 +1,6 @@ | |||
| ORIG_ARGV = ARGV.dup | |||
|
|
|||
| require 'active_support/core_ext/object/blank' | |||
There was a problem hiding this comment.
I already fixed this one. Could you remove it?
…unit In rails#25380 I moved an `active_support/core_ext/object/blank` in the `activesupport/lib/active_support/testing/assertions.rb`, however it caused a chain reaction, resulting in failing railties tests. Moving the require to `railties/test/isolation/abstract_unit.rb` and `activesupport/test/abstract_unit.rb`.
gsamokovarov
force-pushed
the
abstact-unit-presence-require
branch
from
ec41f61
to
4b80a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #25380 I removed an
active_support/core_ext/object/blankrequire in theactivesupport/lib/active_support/testing/assertions.rb, however it caused achain reaction, resulting in failing railties tests. Moving the require to
railties/test/isolation/abstract_unit.rbsolves the problem and keeps therequire close to where it is used.