Update increment! documentation [ci skip] #25427
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
This brings the documentation back in line with reality, but the new behaviour here is set to ship in Rails 5, even though it constitutes several breaking changes. #21979 tries to restore the previous touching behaviour, but the other differences also have the potential to break existing apps. At the very least, I think we need to add a feature toggle to new_framework_defaults.rb for 5.0. What do you think @sgrif? |
|
r? @sgrif |
The `increment!` and `decrement!` methods were recently reimplemented to make them safe to call from multiple connections concurrently. This changed their behaviour in a few ways. Previously they used `update_attribute`, which calls the attribute setter method, runs callbacks, and touches the record. Now they behave more like `update_column`, writing the update to the database directly and bypassing all of those steps.
eugeneius
force-pushed
the
update_increment_documentation
branch
from
cffded5
to
115e314
Compare
|
5.0.0 shipped with this behavour - maybe at this point we should just update the documentation? I've amended my commit to remove |
|
I just ran into this issue of I prefer the convenience of the old functionality but am fine if the new functionality (not calling callbacks) is documented. |
|
r? @kaspth |
Update increment! documentation [ci skip]
|
Thanks! I've backported this to 5-0-stable as well: cfd19c7 |
|
Thank you @kaspth! ❤️ |
|
🤓❤ |
|
This breaking change really hurt our application :( |
The
increment!anddecrement!methods were reimplemented in #11410 to make them safe to call from multiple connections concurrently. This changed their behaviour in a few ways.Previously they used
update_attribute, which calls the attribute setter method, runs callbacks, and touches the record. Now they behave more likeupdate_column, writing the update to the database directly and bypassing all of those steps.The change in behaviour was pointed out on the original pull request: #11410 (comment)