Fix the docs for supported keyword args or Rails 5 style integration controller tests [ci skip] #25450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathamesh-sonpatki
force-pushed
the
fix-testing-guide
branch
from
3787a09
to
75f9696
Compare
|
This needs backport too. |
prathamesh-sonpatki
force-pushed
the
fix-testing-guide
branch
from
75f9696
to
81c5c76
Compare
prathamesh-sonpatki
changed the title
| * `flash`: option with a hash of flash values. | ||
| * `env`: for customizing the request environment as needed. | ||
|
|
||
| * `xhr`: weather the request is Ajax request or not. Can be set to true for marking the request as Ajax. |
There was a problem hiding this comment.
You have a typo here, should be "whether the request"
There was a problem hiding this comment.
Oops. Fixed :)
prathamesh-sonpatki
force-pushed
the
fix-testing-guide
branch
from
81c5c76
to
60b3839
Compare
|
|
||
| ```ruby | ||
| get(:show, params: { id: 12 }, session: { user_id: 5 }) | ||
| get(:show, params: { id: 12 }), as: :json |
There was a problem hiding this comment.
Closing paren is set wrong :)
There was a problem hiding this comment.
How does the as option make sense on get requests?
There was a problem hiding this comment.
@kaspth 👍 Updated example with headers.
prathamesh-sonpatki
force-pushed
the
fix-testing-guide
branch
from
60b3839
to
1013989
Compare
| @@ -695,30 +695,34 @@ end | |||
| In the `test_should_get_index` test, Rails simulates a request on the action called `index`, making sure the request was successful | |||
| and also ensuring that the right response body has been generated. | |||
|
|
|||
| The `get` method kicks off the web request and populates the results into the `@response`. It accepts 4 arguments: | |||
| The `get` method kicks off the web request and populates the results into the `@response`. It can accept upto 6 arguments: | |||
There was a problem hiding this comment.
"up to" should be two words
There was a problem hiding this comment.
Thanks, updated
… controller tests [ci skip] - Fixes rails#25394.
prathamesh-sonpatki
force-pushed
the
fix-testing-guide
branch
from
1013989
to
16283e7
Compare
|
Nice 👍 |
|
@kaspth We need to backport it too :) |
kaspth
added a commit
that referenced
this pull request
Jun 21, 2016
Fix the docs for supported keyword args or Rails 5 style integration controller tests [ci skip]
kaspth
added a commit
to kaspth/rails
that referenced
this pull request
Jun 21, 2016
…uide Fix the docs for supported keyword args or Rails 5 style integration controller tests [ci skip]
|
@prathamesh-sonpatki doh, nice catch! Backported to 5-0-stable @ 91f7779, 5-0-0 @ 662be0c 😁 |
|
Ah, this didn't need to go in to 5-0-0. I was a little too quick there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eileencodes