Switch from XML to JSON in scaffold generator, and use Ruby 1.9 hash style #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of XML It seems like a lot of people are using JSON in their API more than XML nowadays, so Rails should follow that convention by providing the JSON format block in scaffold_controller by default. This patch has been requested by DHH
…troller generator on Ruby 1.9.x The new hash syntax of Ruby 1.9 looks more superior, so we decide to switch to it in the places that appropriate. This patch has been requested by DHH.
…r on Ruby 1.9.x The new hash syntax of Ruby 1.9 looks more superior, so we decide to switch to it in the places that appropriate.
That means if you don't like the new syntax, you can pass --old-style-hash to force Rails to generate code with hash rockets.
|
DHH merged already. :) |
|
This has been merged \o/ |
matthewd
pushed a commit
that referenced
this pull request
Apr 24, 2018
matthewd
pushed a commit
that referenced
this pull request
Apr 24, 2018
matthewd
pushed a commit
that referenced
this pull request
Apr 24, 2018
test gem build in ci process, inspired by issue #256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
As per @dhh's request, I've finished the following patches:
Switch from XML to JSON in scaffold generator
This is really straightforward. Note that in
updateanddestroywe have to return empty hash so that jQuery will understand that the response is correct. That has been patched in https://github.com/rails/rails/blob/master/actionpack/lib/action_controller/metal/responder.rb#L262-278 as well.Use Ruby 1.9 hash style
I've updated scaffold generator and app generator to use Ruby 1.9 hash. I've accomplished it by adding
key_valuemethod which will detect Ruby version and returns the right key-value hash according to the version.I also take it further by adding
--old-style-hashin case someone might want to make their code compatible with 1.8.x, or just sanely hate 1.9 style hash.Please review the patch and see if they're appropriate. Thank you.