Dry downloader

[voxik]

Summary

DRY the Downloader and skip the tests when the donwload fails for some reason (similarly to what MultibyteGraphemeBreakConformanceTest already did).

BTW wouldn't it be better to keep the copies of the files locally then downloading them again and again?

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[rafaelfranca]

Yes. A cache would be good for those files. Could you implement it?

[voxik]

I was thinking about keeping the files in git, probably somewhere among fixtures. I could do that ... But I am afraid that anything beyond that is out of my scope

[rafaelfranca]

I do prefer to not have it in the git repository, a file system cache for it in /tmp seems fine to me.

[rafaelfranca]

For now this seems good to merge so I'm merging.