Eliminate extra template lookup in ActionView::Digestor #25826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me. Any concerns @rafaelfranca ? |
|
|
. We may want to change the API of 
|
Backported in 0ef05cd |
rafaelfranca
added a commit
that referenced
this pull request
Jul 15, 2016
…e-lookups Eliminate extra template lookup in ActionView::Digestor
|
❤️
That was my instinct too and I agree it should be a separate change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PathSet#exists?andPathSet#findboth do the same thing (PathSet#find_all). Theexists?avoidsMissingTemplateerrors when no template is found. This change avoids it by usingfind_all.firstinstead. No behavior change, just one less template lookup.Noticed this while working on #25411.
/cc @dhh @matthewd