sql_for_insert should be called inside exec_insert
#26002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@rails-bot has picked a reviewer for you, use r? to override) |
kamipo
force-pushed
the
sql_for_insert_should_be_called_inside_exec_insert
branch
from
0e51df7
to
11b5d20
Compare
`exec_insert` cannot return last inserted id if `use_insert_returning?` is true. `sql_for_insert` should be called inside `exec_insert`.
kamipo
force-pushed
the
sql_for_insert_should_be_called_inside_exec_insert
branch
from
11b5d20
to
2ed25b3
Compare
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Aug 17, 2016
Because `sql_for_insert` is only called in `use_insert_returning?` is true since rails#26002.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Aug 19, 2016
This reverts rails#23067. rails#23067 is for propagating `pk` value from `sql_for_insert` to `exec_insert` (avoiding extra query for pg adapter). Now `exec_insert` includes `sql_for_insert` since rails#26002 therefore this propagating is no longer needed.
|
@kamipo Would you do me a favor to take a look at rsim/oracle-enhanced#988 which is related with this pull request and give some advice if you have time. I have summarized the current status here. |
kamipo
added a commit
that referenced
this pull request
Jan 11, 2019
Since #26002, `id_value` is no longer passed to `sql_for_insert`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exec_insertcannot return last inserted id ifuse_insert_returning?is true.
sql_for_insertshould be called insideexec_insert.