Fix inconsistent the signature of finder methods for collection association #26009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sgrif (@rails-bot has picked a reviewer for you, use r? to override) |
kamipo
force-pushed
the
fix_inconsistent_finder_methods_signature
branch
5 times, most recently
from
50594d1
to
ad5bddc
Compare
…iation `#second`, `#third`, etc finder methods was added in 03855e7. But the signature of these methods is inconsistent with the original finder methods. And also the signature of `#first` and `#last` methods is different from the original. This commit fixes the inconsistency.
kamipo
force-pushed
the
fix_inconsistent_finder_methods_signature
branch
from
ad5bddc
to
4638067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#second,#third, etc finder methods was added in 03855e7.But the signature of these methods is inconsistent with the original
finder methods. And also the signature of
#firstand#lastmethodsis different from the original. This commit fixes the inconsistency.