add check of argument #26524
Merged
add check of argument #26524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
maclover7
approved these changes
Sep 17, 2016
y-yagi
force-pushed
the
add_check_of_argument
branch
from
9376cda
to
68085e4
Compare
|
Thank you for pointing out! I added the document. How about that? |
prathamesh-sonpatki
suggested changes
Sep 17, 2016
| @@ -361,6 +361,9 @@ def read_multi(*names) | |||
| # the cache with the given keys, then that data is returned. Otherwise, | |||
| # the supplied block is called for each key for which there was no data, | |||
| # and the result will be written to the cache and returned. | |||
| # Therefore, you need to pass a block that returns a data to be written | |||
| # to the cache. If you do not want to write the cache when the cache is | |||
There was a problem hiding this comment.
Instead of that returns a data to, that returns the data to
There was a problem hiding this comment.
I don't know why, but github still marked this as 'Needs change' when you clearly did the thing. Merging.
y-yagi
force-pushed
the
add_check_of_argument
branch
from
68085e4
to
6fee11d
Compare
`#fetch_multi` in case did not cache hit, to write a cache using the block value. https://github.com/rails/rails/blob/master/activesupport/lib/active_support/cache.rb#L383..L384 Therefore, block is a need to pass always, I think should check first.
y-yagi
force-pushed
the
add_check_of_argument
branch
from
6fee11d
to
97544ed
Compare
|
Thanks! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#fetch_multiin case did not cache hit, to write a cache using the block value.https://github.com/rails/rails/blob/master/activesupport/lib/active_support/cache.rb#L383..L384
Therefore, block is a need to pass always, I think should check first.