Undeprecate plural positional argument #26578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```ruby pluralize people.count, 'person', 'people' ``` reads more naturally than ```ruby pluralize people.count, 'person', plural: 'people' ``` so let's not deprecate it. We could label both, but that's a mouthful: ```ruby pluralize people.count, singular: 'person', plural: 'people' ``` (The `plural:` kwarg shipped in 5.0.0, so we're keeping it.)
kaspth
approved these changes
Sep 25, 2016
rafaelfranca
added a commit
that referenced
this pull request
Oct 10, 2016
Undeprecate plural positional argument
|
Merged because I almost removed this code from master 😅 . Backported in d621a26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough deprecation warning. Unclear why it's removed, and it turns out it's just for calling consistency with other helpers. I don't think that flies in this case. Passing one as an unlabeled positional argument and the other as a keyword arg over-emphasizes that one is required (the singular form) and the other is not (since we use the inflector to generate a plural if it's not provided).
Concise and natural to read and write:
Surprise that one of the nouns needs labeling:
So let's just not deprecate the positional arg. (The
plural:kwarg shipped in 5.0.0, so we're keeping it.)We could optionally label both nouns, but that's a mega mouthful:
Partially reverts #20638.