Extract format_colspec to format column spec
#26756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eileencodes (@rails-bot has picked a reviewer for you, use r? to override) |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Feb 17, 2017
Refer these changes at Rails: rails/rails#26756 rails/rails#22589 rails/rails@df84e986721 rails/rails#27884 This commit introduces Virtual column schema dumper format changes.
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Feb 17, 2017
Refer these changes at Rails: rails/rails#26756 rails/rails#22589 rails/rails@df84e986721 rails/rails#27884 This commit introduces Virtual column schema dumper format change: `:type` attribute shown next to column name. Align changes has been introduced by rails/rails@df84e986721 . * Before this commit: ```ruby ActiveRecord::Schema.define(version: 0) do create_table "test_names", force: :cascade do |t| t.string "first_name" t.string "last_name" t.virtual "full_name", limit: 512, as: "\"FIRST_NAME\"||', '||\"LAST_NAME\"", type: :string t.virtual "short_name", limit: 300, as: "COALESCE(\"FIRST_NAME\",\"LAST_NAME\")", type: :string t.virtual "abbrev_name", limit: 100, as: "SUBSTR(\"FIRST_NAME\",1,50)||' '||SUBSTR(\"LAST_NAME\",1,1)||'.'", type: :string t.virtual "name_ratio", as: "LENGTH(\"FIRST_NAME\")*10/LENGTH(\"LAST_NAME\")*10" t.virtual "full_name_length", precision: 38, as: "LENGTH(\"FIRST_NAME\"||', '||\"LAST_NAME\")", type: :integer t.virtual "field_with_leading_space", limit: 300, as: "' '||\"FIRST_NAME\"||' '", type: :string end end ``` * After this commit: ``` ActiveRecord::Schema.define(version: 0) do create_table "test_names", force: :cascade do |t| t.string "first_name" t.string "last_name" t.virtual "full_name", type: :string, limit: 512, as: "\"FIRST_NAME\"||', '||\"LAST_NAME\"" t.virtual "short_name", type: :string, limit: 300, as: "COALESCE(\"FIRST_NAME\",\"LAST_NAME\")" t.virtual "abbrev_name", type: :string, limit: 100, as: "SUBSTR(\"FIRST_NAME\",1,50)||' '||SUBSTR(\"LAST_NAME\",1,1)||'.'" t.virtual "name_ratio", as: "LENGTH(\"FIRST_NAME\")*10/LENGTH(\"LAST_NAME\")*10" t.virtual "full_name_length", type: :integer, precision: 38, as: "LENGTH(\"FIRST_NAME\"||', '||\"LAST_NAME\")" t.virtual "field_with_leading_space", type: :string, limit: 300, as: "' '||\"FIRST_NAME\"||' '" end end ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.