-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No blade on jruby #26833
No blade on jruby #26833
Conversation
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
Looks like some changes to Active Support got rolled up in here 😬 |
blade has a transitive dependency on curses, which is a C ext and does not install on JRuby.
856f7a9
to
a644c07
Compare
Yeah, sorry about that. Too many PRs in flight. |
BTW, I wasn't sure whether to PR against 5-0-stable or master. If it's easier for your process I can go against master. |
Will need to be forward-ported to master |
Was just about to say, is easier if PRs are submitted to master (5.1) than 5-0-stable (5.0) |
Ok, I'll do that going forward. |
Summary
The
blade
library has a transitive dependency oncurses
which is not installable on JRuby. This patch masks it out.