Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No blade on jruby #26833

Merged
merged 1 commit into from
Oct 19, 2016
Merged

No blade on jruby #26833

merged 1 commit into from
Oct 19, 2016

Conversation

headius
Copy link
Contributor

@headius headius commented Oct 19, 2016

Summary

The blade library has a transitive dependency on curses which is not installable on JRuby. This patch masks it out.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rails-bot
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against 5-0-stable. Please double check that you specified the right target!

@headius headius mentioned this pull request Oct 19, 2016
@maclover7
Copy link
Contributor

Looks like some changes to Active Support got rolled up in here 😬

blade has a transitive dependency on curses, which is a C ext and
does not install on JRuby.
@fxn fxn merged commit caa1a7d into rails:5-0-stable Oct 19, 2016
@headius
Copy link
Contributor Author

headius commented Oct 19, 2016

Yeah, sorry about that. Too many PRs in flight.

@headius headius deleted the no_blade_on_jruby branch October 19, 2016 22:18
@headius
Copy link
Contributor Author

headius commented Oct 19, 2016

BTW, I wasn't sure whether to PR against 5-0-stable or master. If it's easier for your process I can go against master.

@maclover7
Copy link
Contributor

Will need to be forward-ported to master

@maclover7
Copy link
Contributor

Was just about to say, is easier if PRs are submitted to master (5.1) than 5-0-stable (5.0)

@headius
Copy link
Contributor Author

headius commented Oct 19, 2016

Ok, I'll do that going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants