Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused RedirectBackError class #26907

Merged
merged 1 commit into from
Oct 27, 2016

Conversation

y-yagi
Copy link
Member

@y-yagi y-yagi commented Oct 26, 2016

Follow up to 333bfd8

@rails-bot
Copy link

r? @arthurnn

(@rails-bot has picked a reviewer for you, use r? to override)

@arthurnn arthurnn merged commit b27a087 into rails:master Oct 27, 2016
@arthurnn
Copy link
Member

thanks

@y-yagi y-yagi deleted the remove_unused_RedirectBackError branch October 27, 2016 03:13
@matthewd
Copy link
Member

@arthurnn we should probably deprecate this

@arthurnn
Copy link
Member

@matthewd as far as I understood, it was deprecated before 333bfd8 , and now it is just removed.

@matthewd
Copy link
Member

My worry is that someone who was just rescuing the exception wouldn't've previously seen the deprecation. But as there isn't much more information for us to give them (e.g., a new name for the constant), on second thought this is probably fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants