Make the tests for uncountability of ascii and non-ascii words uniform #27520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
requested changes
Dec 31, 2016
| def test_pluralize_for_words_with_non_ascii_characters | ||
| ActiveSupport::Inflector.inflections do |inflect| | ||
| inflect.uncountable "猫" | ||
| %w{HTTP 猫}.each do |word| |
There was a problem hiding this comment.
Can we keep them as two tests? I don't see the problem with duplication in tests, in fact I find it easier to run only one test when needed?
prathamesh-sonpatki
force-pushed
the
merge-uncountable-tests-for-inflector
branch
from
1519620
to
f07ea9f
Compare
|
@rafaelfranca Updated! |
prathamesh-sonpatki
changed the title
prathamesh-sonpatki
force-pushed
the
merge-uncountable-tests-for-inflector
branch
from
f07ea9f
to
11b6f9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.