Add first_or_create family of methods to Active Record #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild to Active Record.
This let's you write things like:
User.where(:first_name => "Scarlett").first_or_create!(:last_name => "Johansson", :hot => true)
Related to rails#2420.
|
Thanks, I will review this in due course but it might be a few days. |
|
|
||
| <sql> | ||
| SELECT * FROM clients WHERE (clients.first_name = 'Ryan') LIMIT 1 |
ghost
assigned 
| # | ||
| # Expects arguments in the same format as <tt>Base.create</tt>. | ||
| # | ||
| # ==== Examples |
There was a problem hiding this comment.
Can you add a first example with no arguments to first_or_create? (As I think this will be the most common usage.)
E.g.
User.where(:first_name => 'Scarlett').first_or_create
# => <User id: 1, first_name: 'Scarlett'>Also, I would remove the examples of creating several users at the same time, as I think this is a kind of odd use case and only works because create happens to be implemented that way.
There was a problem hiding this comment.
Both things done in d03aff7.
added 2 commits
September 6, 2011 02:02
…e and removing examples that create several users at the same time (this is confusing and not really helpful).
… family of methods.
|
@jonleighton @tenderlove I know you are busy with lots of stuff but can you take a quick look at this pull request? I think there's not much left to do before merging. |
jonleighton
added a commit
that referenced
this pull request
Sep 8, 2011
Add first_or_create family of methods to Active Record
|
Merged, thanks! |
This was referenced Mar 29, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request let's you write:
Take a look at #2420 for the discussion about this.