activerecord/test: Fix Mysql2ConnectionTest#test_execute_after_disconnect #27621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @arthurnn & @prathamesh-sonpatki
Mysql2ConnectionTest#test_execute_after_disconnect was originally added in #26434 to catch a NoMethodError occurring in execute when the Mysql2Adapter has a nil
@connection
. Pull request #26869 removed the error message check in that test because the error message changed in the mysql2 gem, which caused the test to fail. Now the test wouldn't catch the original bug since theNoMethodError would get turned into a ActiveRecord::StatementInvalid exception.
Check the cause of the StatementInvalid exception to make sure it is of the correct type.