Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activerecord/test: Fix Mysql2ConnectionTest#test_execute_after_disconnect #27621

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

dylanahsmith
Copy link
Contributor

cc @arthurnn & @prathamesh-sonpatki

Mysql2ConnectionTest#test_execute_after_disconnect was originally added in #26434 to catch a NoMethodError occurring in execute when the Mysql2Adapter has a nil@connection. Pull request #26869 removed the error message check in that test because the error message changed in the mysql2 gem, which caused the test to fail. Now the test wouldn't catch the original bug since the
NoMethodError would get turned into a ActiveRecord::StatementInvalid exception.

Check the cause of the StatementInvalid exception to make sure it is of the correct type.

…nect

Mysql2ConnectionTest#test_execute_after_disconnect was originally added to
catch a NoMethodError occuring in execute when the Mysql2Adapter has a nil
`@connection`. Pull request rails#26869 removed the error message check in that
test because the error message changed in the mysql2 gem, which caused the
test to fail. Now the test wouldn't catch the original bug since the
NoMethodError would get turned into a ActiveRecord::StatementInvalid
exception.

Check the cause of the StatementInvalid exception to make sure it is of the
correct type.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@senny senny merged commit a8a97f7 into rails:master Jan 10, 2017
@senny
Copy link
Member

senny commented Jan 10, 2017

Thank you! 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants