Several representation of BigDecimal has changed in Ruby 2.4.0+ [ci skip] #27686
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @arthurnn (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
koic
force-pushed
the
friendly_bigdecimal_inspect
branch
from
da065b9
to
7b3d663
Compare
|
👍 Thank you for your contribution! ❤️ 💚 💙 💛 💜 |
The exact inspect output of a BigDecimal is out of scope for what we're trying to communicate about `dup` and `duplicable?` here. Adding two examples distracts is disctracting, so keep the docs from before since our minimal version is Ruby 2.2.2. [ Koichi ITO, Jon Moss, Kasper Timm Hansen ] This reverts commit 2163874, reversing changes made to 46fdbc5.
|
Hey, thanks for the pull request! I think the extra examples distracts from what the API we're trying to document so I reverted this in 7c3a99e. See that for a more elaborate explanation. I gave you both credit in the commit for good measure ❤️ |
|
@kaspth I saw the above commit message. Thanks for your help 🙏 |
cf. ruby/bigdecimal#42