Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Active Model testing for JRuby #27769

Merged
merged 1 commit into from Feb 24, 2017

Conversation

maclover7
Copy link
Contributor

Summary

Active Model is passing locally on JRuby 9.1.7.0 for me 馃帀

Copy link
Member

@arthurnn arthurnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is passing. i am 馃憤

@rafaelfranca
Copy link
Member

Don't looks like it is passing.

@headius
Copy link
Contributor

headius commented Feb 3, 2017

It doesn't look like the suite ran properly; they failed to negotiate a proper ffi gem before running.

Other builds for rails master have JRuby running activemodel tests just fine, but they fail because they're run along with activejob that has a few failures.

@maclover7
Copy link
Contributor Author

Agree with @headius; the Active Model build is passing, but since Action Mailer + Active Model + Active Job all run in the same Travis CI job, it is showing as failing. I can take a look at solving the Active Job issues on JRuby in a separate PR.

.travis.yml Outdated
@@ -21,6 +21,8 @@ before_install:
- "gem update bundler"
- "[ -f /tmp/beanstalkd-1.10/Makefile ] || (curl -L https://github.com/kr/beanstalkd/archive/v1.10.tar.gz | tar xz -C /tmp)"
- "pushd /tmp/beanstalkd-1.10 && make && (./beanstalkd &); popd"
- gem update --remote bundler
- gem update --system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maclover7
Copy link
Contributor Author

updated, Active Model is still passing on JRuby.

@rafaelfranca rafaelfranca merged commit 09f97c1 into rails:master Feb 24, 2017
@maclover7 maclover7 deleted the jm-jruby-amo branch February 24, 2017 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants