New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Active Model testing for JRuby #27769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is passing. i am 馃憤
Don't looks like it is passing. |
It doesn't look like the suite ran properly; they failed to negotiate a proper Other builds for rails master have JRuby running activemodel tests just fine, but they fail because they're run along with activejob that has a few failures. |
443000f
to
e54b831
Compare
Agree with @headius; the Active Model build is passing, but since Action Mailer + Active Model + Active Job all run in the same Travis CI job, it is showing as failing. I can take a look at solving the Active Job issues on JRuby in a separate PR. |
.travis.yml
Outdated
@@ -21,6 +21,8 @@ before_install: | |||
- "gem update bundler" | |||
- "[ -f /tmp/beanstalkd-1.10/Makefile ] || (curl -L https://github.com/kr/beanstalkd/archive/v1.10.tar.gz | tar xz -C /tmp)" | |||
- "pushd /tmp/beanstalkd-1.10 && make && (./beanstalkd &); popd" | |||
- gem update --remote bundler | |||
- gem update --system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these lines duplicated?
https://github.com/maclover7/rails/blob/e54b8316c8f2f2c9410482362d3f79d3283daf33/.travis.yml#L20..L21
e54b831
to
e50996e
Compare
updated, Active Model is still passing on JRuby. |
Summary
Active Model is passing locally on JRuby 9.1.7.0 for me 馃帀