make backburner integration test to work #27831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, backburner integration test is not running on CI. https://travis-ci.org/rails/rails/jobs/196005322#L610 Using `Backburner::Worker.connection` to check whether beanstalkd is running. But `Backburner::Worker.connection` was removed in backburner 1.2.0. nesquena/backburner@81fde49 Therefore, this check process always becomes false, so the test is no longer done. I fixed it so that check processing is done correctly.
|
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
|
@y-yagi thanks! 👍 Does this need backporting to 5-0-stable and 4-2-stable - what versions of Backburner are we running in the tests there? |
|
Thanks for the review! Backburner 1.3.1 is used for both 5-0-stable and 4-2-stable. Therefore, I think that backporting are need for both branches. Ref: 5-0-stable 4-2-stable |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, backburner integration test is not running on CI.
https://travis-ci.org/rails/rails/jobs/196005322#L610
Using
Backburner::Worker.connectionto check whether beanstalkd isrunning. But
Backburner::Worker.connectionwas removed in backburner1.2.0.
nesquena/backburner@81fde49
Therefore, this check process always becomes false, so the test is no
longer done. I fixed it so that check processing is done correctly.