Remove explicit references to Rails.application.config from AssetPaths in Sprockets helper #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,6 +85,14 @@ module Sprockets | |||
| Rails.application.config.assets.digests | |||
There was a problem hiding this comment.
Should this still be here?
There was a problem hiding this comment.
I believe so. config.assets.digest is a boolean flag whereas config.assets.digests contains the digests which may be loaded from a manifest file. Definitely confusing.
There was a problem hiding this comment.
Ugh, right. I haven't noticed this small detail. :(
josevalim
added a commit
that referenced
this pull request
Sep 1, 2011
Remove explicit references to Rails.application.config from AssetPaths in Sprockets helper
|
Can we have the same for master? |
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves references to
config.assets.compileandconfig.assets.digestto helper level methods so that they may be overriden.