-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for DateTime#blank? #27924
Add test for DateTime#blank? #27924
Conversation
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
@@ -318,6 +318,10 @@ def test_acts_like_time | |||
assert DateTime.new.acts_like_time? | |||
end | |||
|
|||
def test_blank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be test_blank?
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simi thank you :)
15cdb26
to
bf87dae
Compare
@kenta-s are there equivalent tests for |
No, I couldn't find them. Let me add them as well :) |
bf87dae
to
9140720
Compare
@pixeltrix done :) |
Do those classes implement |
Currently there are no tests for
DateTime#blank?
Even after I make the method return
true
as an experiment, all the tests were passed :P