Add default_index_type? to the generic schema dumper doesn't have the knowledge about an index type
#27986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -509,6 +509,10 @@ def combine_bind_parameters( | |||
| result | |||
| end | |||
|
|
|||
| def default_index_type?(index) # :nodoc: | |||
| index.using.nil? || index.using == :btree | |||
There was a problem hiding this comment.
All the adapters have btree?
There was a problem hiding this comment.
sqlite3, oracle-enhanced and sqlserver adapters are always index.using = nil.
- https://github.com/rsim/oracle-enhanced/blob/7d16086ef0f91fa32a19907c35a97c36bcda4c80/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb#L680
- https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/3cee83caa631870f5dcc8dbd89f08da8c30013bc/lib/active_record/connection_adapters/sqlserver/schema_statements.rb#L68
mysql2 and postgresql adapters are index.using = :btree as default.
There was a problem hiding this comment.
So should we move the btree check to the adapters that have btree?
kamipo
force-pushed
the
add_default_index_type
branch
from
ec4f537
to
c5df8e1
Compare
kamipo
commented
Feb 13, 2017
| @@ -509,6 +509,10 @@ def combine_bind_parameters( | |||
| result | |||
| end | |||
|
|
|||
| def default_index_type?(index) # :nodoc: | |||
| index.using.nil? | |||
There was a problem hiding this comment.
Moved the :btree check to the adapters that have :btree.
…he knowledge about an index type
kamipo
force-pushed
the
add_default_index_type
branch
from
c5df8e1
to
3cb27c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.