Make internal methods to private #28052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
force-pushed
the
make_internal_methods_to_private
branch
4 times, most recently
from
f2cd1fd
to
694eb1d
Compare
kamipo
force-pushed
the
make_internal_methods_to_private
branch
from
694eb1d
to
3f0a61e
Compare
kamipo
force-pushed
the
make_internal_methods_to_private
branch
from
3f0a61e
to
ef665e0
Compare
|
Could you rebase it? |
kamipo
force-pushed
the
make_internal_methods_to_private
branch
from
ef665e0
to
4b1e278
Compare
|
Rebased! |
kamipo
force-pushed
the
make_internal_methods_to_private
branch
2 times, most recently
from
0bb0a30
to
a22a838
Compare
kamipo
force-pushed
the
make_internal_methods_to_private
branch
from
a22a838
to
e4108fc
Compare
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Oct 3, 2017
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Oct 6, 2017
…olumn_from_field` Refer rails/rails#28487 rails/rails#28052
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Oct 6, 2017
…olumn_from_field` Refer rails/rails#28487 rails/rails#28052
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Oct 6, 2017
…olumn_from_field` Also removed `new_columns` method Refer rails/rails#28487 rails/rails#28052
This was referenced Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.