Allow skipping of turbolinks for test dummy application for plugin/engine #28120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfonic
changed the title
rafaelfranca
requested changes
Feb 23, 2017
| :skip_active_record, :skip_action_mailer, :skip_javascript, :skip_sprockets, :database, | ||
| :javascript, :quiet, :pretend, :force, :skip | ||
| :skip_active_record, :skip_action_mailer, :skip_javascript, :skip_sprockets, | ||
| :skip_turbolinks, :database, :javascript, :quiet, :pretend, :force, :skip |
There was a problem hiding this comment.
Let's just set it by default to true.
|
Thanks @rafaelfranca! Should I squash these commits immediately and force push or wait until the PR has been approved or you usually do it? EDIT: rebased on top of |
vfonic
force-pushed
the
plugin-generator-skip-turbolinks-dummy
branch
from
459f17a
to
33cf033
Compare
rafaelfranca
approved these changes
Feb 24, 2017
vfonic
force-pushed
the
plugin-generator-skip-turbolinks-dummy
branch
from
33cf033
to
5a3d271
Compare
|
Squashed |
When `rails new plugin` is invoked, turbolinks should be skipped in the dummy test application generated by the plugin generator.
vfonic
force-pushed
the
plugin-generator-skip-turbolinks-dummy
branch
from
5a3d271
to
07ccb1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I think this should be the expected behavior. At least that's what I
expected. Let me know if you think differently. Maybe this PR should be dropped
altogether?
When
rails new pluginis invoked with--skip-turbolinks, turbolinksshould be skipped in the dummy application generated by the plugin
generator.