Fix deserialize with JSON array
#28295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
force-pushed
the
fix_deserialize_with_json_array
branch
from
d4cf7d6
to
6ec2e8a
Compare
kamipo
commented
Mar 6, 2017
| @@ -23,7 +23,7 @@ def deserialize(value) | |||
| when ::String | |||
| type_cast_array(@pg_decoder.decode(value), :deserialize) | |||
| when Data | |||
| deserialize(value.values) | |||
| type_cast_array(value.values, :deserialize) | |||
There was a problem hiding this comment.
values in Data is an array of serialized strings. So we need to deserialize each strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28285.