Use current database in MySQL's table_exists?
#28399
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
FYI: #28068 also fixes this issue. |
|
@kamipo derp; didn't spot that one. shall i close? |
|
This change is preferable to 5-0-stable. Could you open it against that branch? |
This is a minor regression from when we switched from using SHOW TABLES to querying the information_schema for `table_exists?`. SHOW TABLES by default querys the currently selected database but the current implementation defaults to `@config[:database]` if no database name is prepended to the table name. This meant that if you issued a `USE` statement to change database, `table_exists?` gives spurious results as it's still querying `@config[:database]`. The solution is to use the MySQL `DATABASE()` function in place of `@config[:database]`.
mikecmpbll
force-pushed
the
use-current-database-in-mysql-adapter
branch
from
aa918c3
to
078a303
Compare
|
@rafaelfranca done 🐎 |
…t database Related rails#28399.
This is a minor regression from when we switched from using SHOW TABLES
to querying the information_schema for
table_exists?. SHOW TABLES bydefault querys the currently selected database but the current
implementation defaults to
@config[:database]if no database name isprepended to the table name. This meant that if you issued a
USEstatement to change database,
table_exists?gives spurious results asit's still querying
@config[:database].The solution is to use the MySQL
DATABASE()function in place of@config[:database].#18856 (comment)