Fix where_clause#except with specific where value #28497
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
jhawthorn
force-pushed
the
unscope_specific_where_value
branch
from
eca3948
to
e4ced95
Compare
Fixes a regression introduced in 22ca710 where Relation#unscope with a specific where value (vs unscoping the entire where clause) could result in the wrong binds being left on the query. This was caused by an index variable not being incremented properly.
jhawthorn
force-pushed
the
unscope_specific_where_value
branch
from
e4ced95
to
19dc69c
Compare
|
@jhawthorn thanks! |
Fix where_clause#except with specific where value (cherry picked from commit 81b2cd1)
|
Backported to 5-1-stable in f5ada70 |
Fixes #28496
Fixes a regression introduced in 22ca710 where Relation#unscope with a specific where value (vs unscoping the entire where clause) could result
in the wrong binds being left on the query.
This was caused by an index variable not being incremented properly.