Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a failed AR test when running with OracleAdapter #28621

Merged

Conversation

koic
Copy link
Contributor

@koic koic commented Mar 31, 2017

Summary

This PR fixes the following failure when using Oracle (11g) .

% ruby -v
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]

% ARCONN=oracle bundle exec ruby -w -Itest test/cases/scoping/default_scoping_test.rb -n test_with_abstract_class_scope_should_be_executed_in_correct_context

(snip)

Run options: -n test_with_abstract_class_scope_should_be_executed_in_correct_context --seed 45783

# Running:

F

Finished in 0.331497s, 3.0166 runs/s, 6.0332 assertions/s.

  1) Failure:
DefaultScopingTest#test_with_abstract_class_scope_should_be_executed_in_correct_context [test/cases/scoping/default_scoping_test.rb:471]:
Expected /"lions"."is_vegetarian"/ to match "SELECT \"LIONS\".* FROM \"LIONS\" WHERE \"LIONS\".\"IS_VEGETARIAN\" = 0".

1 runs, 2 assertions, 1 failures, 0 errors, 0 skips

It matched the SQL string returned by OracleAdapter.

@rails-bot
Copy link

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@eileencodes eileencodes merged commit fb084e2 into rails:master Mar 31, 2017
@eileencodes
Copy link
Member

Does this need to be backported?

@koic koic deleted the fix_failed_test_when_running_with_oracle branch April 1, 2017 12:37
@koic
Copy link
Contributor Author

koic commented Apr 1, 2017

@eileencodes Thanks for your reply. I confirmed that there is the same problem even in 5-1-stable branch.
Would you please backport this commit? Or I will open a PR of the backport.

eileencodes added a commit that referenced this pull request Apr 1, 2017
…_oracle

Fix a failed AR test when running with OracleAdapter
@eileencodes
Copy link
Member

Backported to 5-1-stable in f8dfd4a. Thanks @koic!

@koic
Copy link
Contributor Author

koic commented Apr 1, 2017

I confirmed this test passed also in 5-1-stable. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants