Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use formatted number as schema version #28678

Merged

Conversation

hedgesky
Copy link
Contributor

@hedgesky hedgesky commented Apr 5, 2017

In short, this PR turns this line in schema.rb:

ActiveRecord::Schema.define(version: 20170404131909)

into this:

ActiveRecord::Schema.define(version: 2017_04_04_131909)

From my point of view, being able to recognize version timestamp at a glance might be very helpful when resolving merge conflicts (which are frequent in schema.rb).

This change is possible because Ruby perfectly understands integers with underscores as delimiters:

2017_04_04_131909 == 20170404131909 # => true

This PR doesn't affect migration naming, only schema dumper.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@sandipransing
Copy link
Contributor

I like the idea 👍

@hedgesky
Copy link
Contributor Author

hedgesky commented Apr 5, 2017

It seems that build fail isn't related to proposed changes: it's caused by puma. Some kind of ports issues.

@rafaelfranca rafaelfranca merged commit bb13c37 into rails:master Apr 8, 2017
kamipo added a commit to kamipo/rails that referenced this pull request Apr 9, 2017
* Fix the comment on `formatted_version`
* Extract `define_params`
* Remove duplicated guard clause for `@version`
pixeltrix added a commit that referenced this pull request Apr 12, 2017
@hedgesky hedgesky deleted the use_formatted_number_as_schema_version branch April 30, 2017 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants