New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks #28678 #28712

Merged

pixeltrix merged 1 commit into rails:master from kamipo:tweaks_28678

Apr 12, 2017

Member

kamipo commented Apr 9, 2017

Fix the comment on formatted_version
Extract define_params
Remove duplicated guard clause for @version


          Tweaks rails#28678

1d05e64

* Fix the comment on `formatted_version`
* Extract `define_params`
* Remove duplicated guard clause for `@version`

maclover7 added the activerecord label

pixeltrix merged commit 2a3b3d2 into rails:master

Contributor

pixeltrix commented Apr 12, 2017

@kamipo thanks 👍

kamipo deleted the tweaks_28678 branch

April 12, 2017 18:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment