Explicitly require AS::Time in AS::Testing::TimeHelpers

[tjschuck]

If you just try to use ActiveSupport::Testing::TimeHelpers standalone by requiring active_support/testing/time_helpers, you currently get an error: NoMethodError: undefined method `change' for 2017-12-14 01:04:44 -0500:Time.

9f6e82e added a dependency on AS::Time by using AS::Time#change.

Here's a script to reproduce the error:

require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"
  gem "activesupport", github: "rails/rails"
end

require "active_support/testing/time_helpers"

require "minitest/autorun"

class BugTest < Minitest::Test
  include ActiveSupport::Testing::TimeHelpers

  def test_stuff
    travel_to Time.new(2017, 12, 14, 01, 04, 44) do
      assert true
    end
  end
end

It currently fails for all 5.x.x versions and master. Ideally, this would be backported to 5-0-stable and 5-1-stable as well.

Thanks!

[rails-bot]

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

[tjschuck]

@pixeltrix I know you just reviewed/merged #28788 as well — I swear I'm not just trawling the codebase looking for these 😜 These two specifically are libs that I wanted to include standalone in a smaller project — I think they're good candidates for that in general. I promise I don't have 40 of these in the hopper behind this one.

[rafaelfranca]

Can we require only what we need. I believe only active_support/core_ext/time/calculations should be sufficient.

[tjschuck]

@rafaelfranca Updated.

[tjschuck]

@rafaelfranca And a note re: #28788 (comment), this PR's repro script above also fails when you include a top-level require "active_support".

[rafaelfranca]

👍 I double checked that before making the comment.

[rafaelfranca]

Backported in b20d7cc and 68aeebf