Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove method_missing in Relation::Delegation #28932

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Remove method_missing in Relation::Delegation #28932

merged 1 commit into from
Jun 28, 2017

Conversation

kamipo
Copy link
Member

@kamipo kamipo commented Apr 29, 2017

The method_missing is never reached since 64c53d7.

@kamipo
Remove method_missing in Relation::Delegation
a44e62b 
The `method_missing` is never reached since 64c53d7.
@rafaelfranca
Copy link
Member

I didn't get form the commit diff, why it is not reached? The class specific relation defines it?

@rafaelfranca
Copy link
Member

Oh. Just saw.

@rafaelfranca rafaelfranca merged commit 1e798cc into rails:master Jun 28, 2017
@kamipo kamipo deleted the remove_method_missing_in_relation_delegation branch June 28, 2017 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
activerecord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamipo @rafaelfranca @maclover7