Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper assertion to be sure the test failed #28954

Merged
merged 1 commit into from May 2, 2017
Merged

Set proper assertion to be sure the test failed #28954

merged 1 commit into from May 2, 2017

Conversation

bogdanvlviv
Copy link
Contributor

No description provided.

@rails-bot
Copy link

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@rails-bot
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against unlock-minitest. Please double check that you specified the right target!

@rafaelfranca
Copy link
Member

Why this change? Is this test already failing?

@bogdanvlviv
Copy link
Contributor Author

bogdanvlviv commented May 2, 2017 •
edited

This assertion was changed on this branch aceee19 and currently, it works.

assert_unsuccessful_run "unit/foo_test.rb", "Failure:\nFooTest#test_truth" says that https://github.com/rails/rails/pull/28954/files#diff-65453a0a9b6494ff2c43717c69be4c4aR52 fails. On my opinion it is more proper assertion than assert with "Expected false to be truthy"

@rafaelfranca rafaelfranca merged commit bbf0773 into rails:unlock-minitest May 2, 2017
@bogdanvlviv bogdanvlviv deleted the set-proper-assertion-that-test-failed branch May 2, 2017 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eileencodes eileencodes

Labels
railties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bogdanvlviv @rails-bot @rafaelfranca @eileencodes @maclover7