[ci skip] explain async queue and rake tasks #29020
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
guides/source/active_job_basics.md
Outdated
| @@ -310,6 +310,12 @@ UserMailer.welcome(@user).deliver_now | |||
| UserMailer.welcome(@user).deliver_later | |||
| ``` | |||
|
|
|||
| NOTE: Using the asynchronous queue from a rake task (for example, to | |||
There was a problem hiding this comment.
Can you capitalize all instances of Rake?
guides/source/active_job_basics.md
Outdated
| send an email using `.deliver_later`) will generally not work because rake will | ||
| likely end, causing the in-process thread pool to be deleted, before any/all | ||
| of the `.deliver_later` emails are processed. To avoid this problem, use | ||
| `.deliver_now` or run a persistent queue in development as well. |
|
Can we/should we just fix this instead? |
|
@maclover7 - done |
|
@maclover7 -- do my changes look ok to you? @matthewd -- I'm not sure how to go about fixing this. I think (?) it would involve modifying |
|
Going to merge as is -- better to get the docs fix in now :) |
[ci skip]
Small update to the guide for ActiveJob to point out a problem that might commonly occur in development when using the Async Queue with rake tasks. Includes advice on how to solve it.