Ensure fixtures are loaded for FoxyFixturesTest #29298
Conversation
Ensure that the fixtures are properly loaded for FoxyFixturesTest When tests are randomized, FoxyFixturesTest often fails due to unloaded fixtures.
|
|
|
AFAICS, this is actually working around a bug in AR::Fixtures. This cut-down test fails on master: require "cases/helper"
require "models/parrot"
require "models/treasure"
class A < ActiveRecord::TestCase
fixtures :parrots
def test_fixtures_loaded
# Dusty may or may not be present, depending on whether some other
# test has loaded the :live_parrots fixture.
assert_equal [nil, "Curious George", "King Louis", "frederick", "polly"], Parrot.order(:name).pluck(:name) - ["Dusty Bluebird"]
end
end
class B < ActiveRecord::TestCase
fixtures :parrots, :live_parrots
def test_fixtures_loaded
assert_equal [nil, "Curious George", "Dusty Bluebird", "King Louis", "frederick", "polly"], Parrot.order(:name).pluck(:name)
end
endSpecifically, |
|
@matthewd interesting, so we're losing the That would make sense for similar failures I've been catching. |
|
Right. Because we first filter the requested fixtures to skip any that are already loaded, and then we empty out the table as part of inserting the loaded fixtures. A perfectly fine pair of strategies, unless two sets of fixtures are using the same table. Assuming my intuition of the problem is right, I think we need to group the requested fixtures by their table name first, then decide whether the whole group can be skipped (because they're all already loaded) or not (if any of them are not). Want to take a look? |
|
Yeah, I'll take a look and work on that. 👍 |
Problem
``` ruby
class A < ActiveRecord::TestCase
fixtures :parrots, :cars
def test_fixtures_loaded
# Dusty may or may not be present, depending on whether some other
# test has loaded the :live_parrots fixture.
assert_equal [nil, "Curious George", "King Louis", "frederick", polly"], Parrot.order(:name).pluck(:name) - ["Dusty Bluebird"]
end
end
class B < ActiveRecord::TestCase
fixtures :parrots, :live_parrots, :cars
def test_fixtures_loaded
assert_equal [nil, "Curious George", "Dusty Bluebird", "King Louis", "frederick", "polly"], Parrot.order(:name).pluck(:name)
end
end
```
If Class B runs after class A, class B's test will fail. Because
:parrots is already cached, it skips the fixture, but when it gets to
:live_parrots, it drops the table and loads up the :live_parrots
fixtures.
Solution
Keep a map of fixtures by table. If when it comes time to create
fixtures and the fixtures for the table match what is cached, then we
can skip creating them in the database. If the fixtures are short of
what we have cached, then the database needs to be cleaned to remove old
records.
See the conversation on rails#29298 for
more information.
NOTE: Related to the Unlock minitest for Rails' test suite PR - #29271
Failing Seed
bin/test --seed 59389 test/cases/fixtures_test.rbWhen tests are randomized, sometimes FoxyFixturesTests are failing due to unloaded
fixtures.
Solution
I followed along with what many of the other tests are doing in the file to bypass this issue by using
self.use_transactional_tests = false.