Collection proxy loses its proxy_association when scoped further

[laserlemon]

Say I have these GitHub-style models,

class User < ActiveRecord::Base
  has_many :projects do
    def personal
      where(:owner => proxy_association.owner.name)
    end

    def personal_first
      order("projects.owner <> '#{proxy_association.owner.name}'")
    end

    def visible_to(user)
      user == proxy_association.owner ? scoped : where(:private => false)
    end
  end
end

class Project < ActiveRecord::Base
end

Through the :projects association, I can get:

• Only personal projects: @user.projects.personal
• Projects ordered so the personal projects come first: @user.projects.personal_first
• Projects that a user is allowed to see: @user.projects.visible_to(current_user)

The problem is that if I combine any two of these methods, it bombs, complaining about there being no proxy_association method defined on ActiveRecord::Relation.

I've updated the collection proxy to pass its @association on to further scopes by opening up a proxy_association accessor on ActiveRecord::Relation. I'd love to get your feedback. Thank you.

[joshpencheon]

Seems sensible, +1.

[robmack]

+1