Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure false is preserved in attr serialization #29536

Merged
merged 1 commit into from Jul 1, 2017

Conversation

nickrivadeneira
Copy link
Contributor

Summary

Roundtrip YAML serialization would result in false values coming back as nil. For example:

record = SomeModel.new(some_boolean: false)
dumped = YAML.load(YAML.dump(record))
dumped.some_boolean # => nil

Note about the implementation:

  • type and original_attribute have the same presence check. I didn't update these because I wanted to keep the change specific to the problem I encountered, but I'd be happy to update those lines as well.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@matthewd matthewd merged commit 4fd4d36 into rails:master Jul 1, 2017
@matthewd
Copy link
Member

matthewd commented Jul 1, 2017

Thanks!

type and original_attribute have the same presence check

Without checking closely, I doubt either of those expect to contain false, so this seems sufficient.

@nickrivadeneira nickrivadeneira deleted the fix-yaml branch July 5, 2017 12:43
sgrif pushed a commit that referenced this pull request Aug 8, 2017
Ensure `false` is preserved in attr serialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants