Polymorphic with optimistic lock and counter cache should be destroyed

[dmitry]

Polymorphic record with optimistic locking and counter cache should be destroyed without catching the ActiveRecord::StaleObjectError. It works fine with has_many, but not works with polymorphic has_many. It also might not work with has_one.

Issue #2954

[dmitry]

Anyone know how is better to fix it?

This code should be removed, because it's not safe:

                # No point in executing the counter update since we're going to destroy the parent anyway
                counter_method = ('belongs_to_counter_cache_before_destroy_for_' + self.class.name.downcase).to_sym
                if(o.respond_to? counter_method) then
                  class << o
                    self
                  end.send(:define_method, counter_method, Proc.new {})
                end

[dmitry]

Please include this fix. Thank you!

[dmitry]

@tenderlove Hope you can look into this.