Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused aliased_table_name in Association #29616

Merged
merged 1 commit into from Jun 29, 2017
Merged

Remove unused aliased_table_name in Association #29616

merged 1 commit into from Jun 29, 2017

Conversation

kamipo
Copy link
Member

@kamipo kamipo commented Jun 28, 2017

aliased_table_name in Association was added at a3502c4.
aliased_table_name in JoinDependency (added at 55854c4) is used, but
it looks like that added one in Association is never used from the
beginning.

@kamipo
Remove unused aliased_table_name in Association
4aa4a44 
`aliased_table_name` in `Association` was added at a3502c4.
`aliased_table_name` in `JoinDependency` (added at 55854c4) is used, but
it looks like that added one in `Association` is never used from the
beginning.
@rafaelfranca rafaelfranca merged commit 4448873 into rails:master Jun 29, 2017
@kamipo kamipo deleted the remove_unused_aliased_table_name branch June 29, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamipo @rafaelfranca