Should be appear deprecation message for every call #29649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it worth bothering with this? As it's a deprecated path already, I was thinking we could just leave it going through |
kamipo
force-pushed
the
should_be_appear_deprecation_message_for_every_call
branch
from
2ae9233
to
3c2a32b
Compare
kamipo
commented
Jul 1, 2017
| @@ -91,7 +84,6 @@ def method_missing(method, *args, &block) | |||
| elsif arel.respond_to?(method) | |||
| ActiveSupport::Deprecation.warn \ | |||
| "Delegating #{method} to arel is deprecated and will be removed in Rails 6.0." | |||
| self.class.delegate method, to: :arel | |||
There was a problem hiding this comment.
Yeah, I agree with you. I changed to remove the delegate line.
kamipo
force-pushed
the
should_be_appear_deprecation_message_for_every_call
branch
from
3c2a32b
to
893f127
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #29619 (comment)