Fix Parameters configuration integration tests #29677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugeneius
commented
Jul 4, 2017
|
|
||
| app "development" | ||
|
|
||
| ActionController::Base.object_id # force lazy load hooks to run |
There was a problem hiding this comment.
This is pretty ugly, but I couldn't come up with a better way to trigger the lazy load hooks.
Just referencing ActionController::Base without calling a method on it resulted in this warning:
railties/test/application/configuration_test.rb:1204: warning: possibly useless use of :: in void context
These tests relied on `ActionController::Parameters` being configured as part of the boot process; since that now happens lazily we need to force `ActionController::Base` to load so that we can test the behaviour. The new tests added here ensure that `ActionController::Parameters` can be configured from an initializer, which was broken until recently.
eugeneius
force-pushed
the
parameters_configuration_tests
branch
from
3d903f3
to
c1d01b7
Compare
eugeneius
changed the title
|
4c8332c broke the Railties test suite, as the tests for the Those tests needed the same fix as the new tests being added here: forcing |
eugeneius
force-pushed
the
parameters_configuration_tests
branch
from
c1d01b7
to
458a550
Compare
rafaelfranca
added a commit
that referenced
this pull request
Jul 5, 2017
Fix Parameters configuration integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests ensure that
ActionController::Parameterscan be configured from an application initializer, which was recently fixed in 4c8332c.r? @rafaelfranca