Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with non-english character URL #2982

Closed
wants to merge 2 commits into from
Closed

Problem with non-english character URL #2982

wants to merge 2 commits into from

Conversation

tanin47
Copy link

@tanin47 tanin47 commented Sep 12, 2011

Unescaping URL before it is processed, otherwise, there would be a problem with non-english character URL. Please see: #2703 (comment)

Tanin Na Nakorn added 2 commits September 8, 2011 12:52
@dmathieu
Copy link
Contributor

Could you rebase your commits into one please ?
There's also a test missing :(

@kennyj
Copy link
Contributor

kennyj commented Feb 5, 2012

I think that this issue was fixed on 3-1-stable, 3-2-stable, and master.
I think that I should close this issue. What do you think ?

BTW, I cannot find a testcase for non english filename, and I'll send PR for it.

kennyj added a commit to kennyj/rails that referenced this pull request Feb 5, 2012
josevalim pushed a commit that referenced this pull request Feb 5, 2012
Add a testcase for non english filename. Related to #2982.
@kennyj
Copy link
Contributor

kennyj commented Feb 6, 2012

Hi ! @tanin47
I'm closing this issue, because it seems that this issue is fixed already on 3-1-stable, 3-2-stable, master.
Please comment to this issue, if needed :-)

@kennyj kennyj closed this Feb 6, 2012
@tanin47
Copy link
Author

tanin47 commented Feb 7, 2012

Alright :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants