Fix find_by with range conditions
#29842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
force-pushed
the
fix_find_by_with_range
branch
from
07ea85a
to
39562b7
Compare
meinac
reviewed
Jul 19, 2017
| @@ -192,7 +192,9 @@ def find_by(*args) # :nodoc: | |||
| hash = args.first | |||
|
|
|||
| return super if !(Hash === hash) || hash.values.any? { |v| | |||
| v.nil? || Array === v || Hash === v || Relation === v || Base === v | |||
| case v | |||
| when NilClass, Array, Range, Hash, Relation, Base then true | |||
There was a problem hiding this comment.
This can be better written like:
types = [NilClass, Array, Range, Hash, Relation, Base].freeze
v.class.in?(types)it's a little bit odd to have a case statement which has only one branching and returns true.
There was a problem hiding this comment.
v.class.in?(types) is not a same with when *types.
Post.new.class is Post, not Base.
Post.all.class is Post::ActiveRecord_Relation, not Relation.
`StatementCache` doesn't support range conditions. So we need to through the args to `FinderMethods#find_by` if range value is passed.
kamipo
force-pushed
the
fix_find_by_with_range
branch
from
39562b7
to
0d56480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatementCachedoesn't support range conditions. So we need to throughthe args to
FinderMethods#find_byif range value is passed.