Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove depreciated assertion to eliminate warning #29921

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

xtina-starr
Copy link
Contributor

This PR removes the following warning by using assert_nil over assert_equal which is depreciated.

Use assert_nil if expecting nil from .../rails/activesupport/test/hash_with_indifferent_access_test.rb:563:in `test_double_conversion_with_nil_key'. This will fail in MT6.

Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com>
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca
Copy link
Member

Can you seach all the places that does that and remove they in one single commit?

@xtina-starr
Copy link
Contributor Author

$ ag "assert_equal nil" .
activesupport/test/hash_with_indifferent_access_test.rb
563:    assert_equal nil, h[:undefined_key]

After executing the above it looks like that's the only place assert_equal is used.

@rafaelfranca rafaelfranca merged commit 39c0362 into rails:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants