Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Adding jdbcmysql support to new rails template. #300

Closed
wants to merge 4 commits into from

Conversation

arunagw
Copy link
Member

@arunagw arunagw commented Apr 22, 2011

I think we need to start adding this support.

This full support need lot's more commits :-)

@vishnuatrai
Copy link
Contributor

Seems like Jruby template is comming with new rails version.

@josevalim
Copy link
Contributor

Summoning @tenderlove.

@tenderlove
Copy link
Member

Seems fine to me. I'll merge when I get to my machine, or you can merge.

Aaron Patterson
http://tenderlovemaking.com/

On Apr 22, 2011, at 5:14 PM, josevalimreply@reply.github.com wrote:

Summoning @tenderlove.

Reply to this email directly or view it on GitHub:
#300 (comment)

@atambo
Copy link
Contributor

atambo commented Apr 22, 2011

Only jdbcmysql? What about all the others:

https://github.com/nicksieger/activerecord-jdbc-adapter

@arunagw
Copy link
Member Author

arunagw commented Apr 22, 2011

@atambo they are in queue. Will come for sure. :-)

@arunagw
Copy link
Member Author

arunagw commented Apr 25, 2011

@tenderlove If we can apply these changes. Then we can come up with more changes for JDBC databases.

@tenderlove
Copy link
Member

Should be merged, so closing.

@tenderlove tenderlove closed this Apr 25, 2011
arunagw pushed a commit to arunagw/rails that referenced this pull request Apr 25, 2011
Start Adding jdbcmysql support to new rails template.
@nicksieger
Copy link
Contributor

I'm fine with these jdbc* adapters present but do note that the non-jdbc names work fine too as long as you have activerecord-jdbc-adapter in Gemfile. In fact, what we need is to modify Gemfile to include ar-jdbc when you select jdbc* for "rails new". Like this.

@arunagw
Copy link
Member Author

arunagw commented Apr 26, 2011

@nicksieger we are just adding an option to generate the templates over here.

rails new -d jdbcmysql

Will do database.yml changes and Gemfile changes.

If we use the non-jdbc names then we need to pass some extra args here.

After running with jdbc* we are fixing database.rake to create, drop and etc database operation.

matthewd added a commit that referenced this pull request Apr 24, 2018
Allow for alias omission in aggregate expressions
matthewd pushed a commit that referenced this pull request Apr 24, 2018
This reverts commit 36836fa, reversing
changes made to 53bc842.
matthewd pushed a commit that referenced this pull request Apr 24, 2018
This reverts commit 9b92af7.

beta2 is out, and we've fixed the issue that this caused in Rails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants