Handling add/remove to/from migration edge cases #30011
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
@guilherme thanks for the PR - what happens when you do |
guilherme
force-pushed
the
fix-migration-generator-special-cases
branch
from
6f19e2a
to
1db284e
Compare
|
@pixeltrix it works fine. I've just updated the PR with the scenario that I am having the issue. I tried to generalize and I thought the test was failing for that generic case but it wasn't, just double checked. My bad. |
guilherme
force-pushed
the
fix-migration-generator-special-cases
branch
3 times, most recently
from
9a21c9c
to
bd8da74
Compare
| @@ -28,7 +28,7 @@ def create_migration_file | |||
| def set_local_assigns! | |||
| @migration_template = "migration.rb" | |||
| case file_name | |||
| when /^(add|remove)_.*_(?:to|from)_(.*)/ | |||
| when /^(add)_.*_(?:to)_(.*)/, /^(remove)_.*?_(?:to|from)_(.*)/ | |||
There was a problem hiding this comment.
The same change (and test) should be made to allow migration = "remove_email_address_from_sent_to_user"
The uncaptured groups can then be removed entirely:
when /^(add)_.*_to_(.*)/, /^(remove)_.*_from_(.*)/There was a problem hiding this comment.
thanks for the feedback! I was trying to come up with a table name with "to" on the title but couldn't find it :)
guilherme
force-pushed
the
fix-migration-generator-special-cases
branch
from
bd8da74
to
b63db87
Compare
| @@ -73,6 +84,17 @@ def test_remove_migration_with_attributes | |||
| end | |||
| end | |||
|
|
|||
| def test_remove_migration_with_table_having_from_in_title | |||
There was a problem hiding this comment.
test_remove_migration_with_table_having_fromto_in_title
Making sure the table name is parsed correctly when an add/remove column migration have 'from'/'to' in the table name.
guilherme
force-pushed
the
fix-migration-generator-special-cases
branch
from
b63db87
to
1cc6c74
Compare
Making sure the table name is parsed correctly when an add/remove column migration have 'from' in the table name.