Deprecate LoadError::REGEXPS constant
#30052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
lugray
approved these changes
Aug 3, 2017
|
I think we could safely just remove this without deprecation -- it's pretty clearly not something we intended to make public, and I see no reason people would've been using it. But if we do want to deprecate, we should use DeprecatedConstantAccessor (and teach it to handle constants that are not being replaced with other constants), not implement it inline. |
|
I agree that we should just remove it. |
since 4ad1a52, `LoadError::REGEXPS` is no longer needed.
y-yagi
force-pushed
the
deprecate_load_error_regexps
branch
from
a710f3f
to
23106de
Compare
|
Thanks for your feedback. OK, I just removed the constant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since 4ad1a52,
LoadError::REGEXPSis no longer needed.