Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename azure storage service #30057

Merged
merged 1 commit into from Aug 4, 2017

Conversation

dixpac
Copy link
Contributor

@dixpac dixpac commented Aug 3, 2017

Azure is not the most correct name. Azure is service that contains storage,database,etc...(same as aws or google cloud).
Renaming this to AzureStorage would be more correct. If AzureStorage is not the best name we could consider abbreviation such as MAS (same approach as to GCS)

r? @dhh
cc @georgeclaghorn

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @dhh (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rails-bot
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against active-storage-import. Please double check that you specified the right target!

@dhh dhh merged commit 3179f08 into rails:active-storage-import Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants