Fix format of generator docs [ci skip] #30259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@rails-bot has picked a reviewer for you, use r? to override) |
Why? |
|
I thought it would be better that |
yhirano55
force-pushed
the
fix_format_of_generator_docs
branch
from
88973b0
to
e47bcb9
Compare
kamipo
reviewed
Aug 15, 2017
| @@ -377,7 +377,7 @@ def bundle_command(command) | |||
| say_status :run, "bundle #{command}" | |||
|
|
|||
| # We are going to shell out rather than invoking Bundler::CLI.new(command) | |||
| # because `rails new` loads the Thor gem and on the other hand bundler uses | |||
| # because +rails new+ loads the Thor gem and on the other hand bundler uses | |||
There was a problem hiding this comment.
Actually this is a comment in the method, not a doc. It is no worth to change to rdoc format.
There was a problem hiding this comment.
fmm.., I understood it.
There was a problem hiding this comment.
@kamipo Thanks for your comment. I'll study more rdoc specifications.
yhirano55
force-pushed
the
fix_format_of_generator_docs
branch
from
e47bcb9
to
56643d4
Compare
yhirano55
force-pushed
the
fix_format_of_generator_docs
branch
from
56643d4
to
f2007bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
actions.rb.Unify typewriter style to++inactions.rb.Replace quote style with typewriter style inapp_base.rb.